feat: compatibility with axallocator#2
Merged
ZR233 merged 2 commits intoarceos-hypervisor:mainfrom Mar 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds compatibility with the axallocator crate by replacing the locally-defined allocator traits (BaseAllocator, ByteAllocator, PageAllocator, IdAllocator, AllocError, AllocResult) with re-exports from axallocator = "0.2". This enables the crate to interoperate with the broader axallocator ecosystem.
Changes:
- Replaces locally-defined traits and error types in
src/lib.rswithpub use axallocator::{...}re-exports - Adds
BaseAllocatorimplementation forSlabByteAllocatorto satisfy the trait requirement fromaxallocator - Updates test assertions from
assert_eq!(..., Err(...))toassert!(matches!(...))for improved ergonomics
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib.rs |
Removes locally-defined trait/type definitions and replaces them with pub use axallocator::{...} |
src/slab/slab_byte_allocator.rs |
Adds BaseAllocator impl for SlabByteAllocator and imports it directly from axallocator |
Cargo.toml |
Adds axallocator = "0.2" as a required dependency; removes trailing blank lines |
tests/integration_test.rs |
Converts two assert_eq! error assertions to assert!(matches!(...)) form |
tests/dma32_pages_test.rs |
Consolidates two-step error assertions into a single assert!(matches!(...)) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZR233
approved these changes
Mar 5, 2026
Copilot AI
added a commit
that referenced
this pull request
Mar 5, 2026
Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>
ZR233
added a commit
that referenced
this pull request
Mar 5, 2026
* Initial plan * chore: bump version to 0.2.0 Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com> * chore: remove deprecated bench feature Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com> * docs: complete CHANGELOG for 0.2.0 with entries from PRs #1 and #2 Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com> Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.